Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix live reloading deletion issues #6870

Merged
merged 5 commits into from
Nov 2, 2021
Merged

Conversation

emmatown
Copy link
Member

@emmatown emmatown commented Nov 2, 2021

Basically, globs are Annoying and bad for what we were using them for. Tested this on Windows and it still works. Also, note @nodelib/fs.walk is what fast-glob uses internally.

@changeset-bot
Copy link

changeset-bot bot commented Nov 2, 2021

🦋 Changeset detected

Latest commit: e236611

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@keystone-next/keystone Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 2, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/Gb58LdVyBveV67Vd8DXszbsvqLUy
✅ Preview: https://keystone-next-docs-git-fix-live-reloading-del-358397-keystonejs.vercel.app

@vercel vercel bot temporarily deployed to Preview November 2, 2021 05:49 Inactive
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 2, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@emmatown emmatown requested a review from a team November 2, 2021 05:50
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 2, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@emmatown emmatown merged commit 8dac6bb into main Nov 2, 2021
@emmatown emmatown deleted the fix-live-reloading-deletion-issues branch November 2, 2021 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants