Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default description of timestamp field #8706

Merged
merged 3 commits into from
Aug 30, 2023

Conversation

wysher
Copy link
Contributor

@wysher wysher commented Jul 20, 2023

before:

before

after:
after


I find this additional info message in timestamp redundant, so I introduce way to disable it.
With createdAt it's shown only on create, but for updatedAt it's ALWAYS visible in ItemView.

I'm not sure about option name, please let me know if there's better one. :)

EDIT:
here's how it looks for updatedAt - message is always visible. In my case on sidebar.
updatedat

@changeset-bot

This comment was marked as resolved.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 20, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 06d757b:

Sandbox Source
@keystone-6/sandbox Configuration

@wysher wysher force-pushed the timestap-ui-hideNowInfo-option branch from 68b0776 to dd81a4d Compare July 20, 2023 18:57
@dcousens
Copy link
Member

I understand the motivation behind this, as I don't like it either.

However, won't this be misleading if the field is manually set? Maybe if db.updatedAt is configured, the field should default to read-only too?

@dcousens dcousens requested a review from borisno2 July 30, 2023 23:20
@dcousens
Copy link
Member

dcousens commented Jul 30, 2023

I honestly think we should probably remove the message completely.

We shouldn't be differentiating the UI behaviour of this field for db.updatedAt, when the usual workflow for these considerations would be for the developer to add a ui.description.

@dcousens dcousens force-pushed the timestap-ui-hideNowInfo-option branch from 8e2156b to 25b4edb Compare August 29, 2023 23:43
@dcousens dcousens changed the title Add ui.hideNowInfo option to timestamp field Remove default description of timestamp field Aug 29, 2023
@dcousens dcousens assigned dcousens and unassigned borisno2 Aug 29, 2023
@dcousens dcousens force-pushed the timestap-ui-hideNowInfo-option branch from e7d49af to d7afc80 Compare August 29, 2023 23:56
@dcousens dcousens force-pushed the timestap-ui-hideNowInfo-option branch from d7afc80 to 06d757b Compare August 29, 2023 23:58
@dcousens dcousens merged commit fa0f6be into keystonejs:main Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants