Use required types internally for hooks #8808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcousens
commented
Sep 18, 2023
| @@ -299,13 +299,10 @@ async function getResolvedData( | |||
| resolvedData = Object.fromEntries( | |||
| await Promise.all( | |||
| Object.entries(list.fields).map(async ([fieldKey, field]) => { | |||
| if (field.hooks.resolveInput === undefined) return [fieldKey, resolvedData[fieldKey]]; | |||
There was a problem hiding this comment.
Replaced by defaultFieldHooksResolveInput
dcousens
commented
Sep 18, 2023
| const fieldsErrors: { error: Error; tag: string }[] = []; | ||
| await Promise.all( | ||
| Object.entries(list.fields).map(async ([fieldKey, field]) => { | ||
| if (shouldRunFieldLevelHook(fieldKey)) { | ||
| try { | ||
| await field.hooks[hookName]?.({ fieldKey, ...args }); | ||
| await field.hooks[hookName]({ fieldKey, ...args } as any); // TODO: FIXME any |
There was a problem hiding this comment.
I think runSideEffectOnlyHook will be removed soon, so this is less of a concern
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ab4fa3c:
|
borisno2
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title suggests, this pull requests changes the types of the resolved hooks to always be
requiredand easily and consistently differentiable. The type verbosity has increased a little, but that has thankfully decreased the complexity of reading the hook types.