Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(next.config): ScottAgirs: remove deprecated appDir flag #8824

Merged
merged 3 commits into from
Sep 25, 2023
Merged

chore(next.config): ScottAgirs: remove deprecated appDir flag #8824

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8f81c3
chore: remove deprecated `appDir` flag
ScottAgirs Sep 22, 2023
0ecab83
chore: Changeset 🦋
ScottAgirs Sep 22, 2023
4f5b2a9
update changeset
dcousens Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/strong-swans-destroy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@keystone-6/example-framework-nextjs-app-directory': patch
'@keystone-6/core': patch
---

Removed deprecated appDir flag from next.config
2 changes: 0 additions & 2 deletions examples/framework-nextjs-app-directory/next.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ import withPreconstruct from '@preconstruct/next';

export default withPreconstruct({
experimental: {
appDir: true,

// without this, 'Error: Expected Upload to be a GraphQL nullable type.'
serverComponentsExternalPackages: ['graphql'],
},
Expand Down
3 changes: 0 additions & 3 deletions packages/core/src/admin-ui/templates/next-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ export const nextConfigTemplate = (basePath?: string) =>
eslint: {
ignoreDuringBuilds: true,
},
experimental: {
appDir: false,
},
// We use transpilePackages for the custom admin-ui pages in the ./admin folder
// as they import ts files into nextjs
transpilePackages: ['../../admin'],
Expand Down