-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update workspace version constraints #8864
chore: update workspace version constraints #8864
Conversation
a78ad6a
to
c5b8391
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 96d6f44:
|
We use the following to publish keystone/.github/workflows/publish.yml Line 26 in 41276b6
Are we guaranteed that Love this initiative by the way, and maybe |
@dcousens changesets is still necessary to detect which packages need a patch/minor/major bump. So that functionality stays.
https://github.com/changesets/changesets/blob/main/docs/command-line-options.md#publish the The For publishing e.g. using |
|
c5b8391
to
07b9900
Compare
update packages/* deps fix build of local installation of keystone-6 core
07b9900
to
4a64956
Compare
@@ -10,7 +10,7 @@ | |||
"postinstall": "keystone postinstall" | |||
}, | |||
"dependencies": { | |||
"@keystone-6/cloudinary": "workspace:^", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For posterity
I didn't update the examples with the workspace: prefix as they should be easily copiable.
Agreed 💙
Updates the version constraints of all workspaces (except examples folder). The version constraints with workspaces are supported
When publishing packages that contain the
workspace:
key in the version constraint, pnpm will automatically inject the correct version of the workspace package.https://pnpm.io/workspaces#publishing-workspace-packages
I didn't update the examples with the
workspace:
prefix as they should be easily copiable.