Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump next major version to 14.x #9170

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

direisc
Copy link
Contributor

@direisc direisc commented Jun 12, 2024

Next has an active vulnerability https://security.snyk.io/package/npm/next/13.5.4
Bump the next version to higher version.

I caught some issues running tests locally. If someone can help, I can try to solve the possible issues.

Copy link

codesandbox-ci bot commented Jun 12, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0873c2c:

Sandbox Source
@keystone-6/sandbox Configuration

@dcousens dcousens self-assigned this Jun 12, 2024
@dcousens dcousens self-requested a review June 12, 2024 10:01
@dcousens dcousens added the dependencies Related to our dependencies label Jun 12, 2024
@direisc
Copy link
Contributor Author

direisc commented Jun 12, 2024

@dcousens the Experimental ESM Externals flags are set to loose to solve an issue when building admin UI.
This is related to an issue when building a react-day-picker peer dependency with no proper type (ESM/CommonJS).

NextJS shows some ways to solve it at https://nextjs.org/docs/messages/import-esm-externals
The workaround to don't need to fix the type of project or work at react-day-picker is adding experimental: { esmExternals: 'loose' }, to let the Next build try to solve the import.

@direisc
Copy link
Contributor Author

direisc commented Jun 12, 2024

To clarify the issue around react-day-picker:

Screenshot 2024-06-12 at 12 34 55

@dcousens dcousens merged commit 2f46896 into keystonejs:main Jun 12, 2024
43 checks passed
@dcousens
Copy link
Member

dcousens commented Jun 12, 2024

Thanks @direisc, this is really appreciated 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related to our dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants