Use app router template #9186

gautamsi · 2024-06-25T05:17:07Z

Blocked by

Return ResolvedKeystoneConfig instead of KeystoneConfig #9189

This PR updates the template to generate the App router, default to typescript version which can be turned off by setting config.ui.tsx = false

What is completed/Verified:

Pending:

Documentation
fixing final set of failing tests

@dcousens can you create a v-next branch which should be actual target for these PRs instead of main

For anyone interested in testing this out, I have published temporary packages (use at your own risk) I have been using it with very large project of mine.
@k6js-next/core-next@0.0.0-20240905-01
@k6js-next/auth-next@0.0.0-20240905-01

to use this you have to specify resolutions, for yarn I do it like this in (root package.json in monorepo)

"resolutions": {
    "graphql": "16.8.1",
    "next": "14.2.5",
    "react": "^18.3.1",
    "react-dom": "^18.3.1",
    "@keystone-6/core": "npm:@k6js-next/core-next@0.0.0-20240905-01",
    "@keystone-6/auth": "npm:@k6js-next/auth-next@0.0.0-20240905-01"
  }

codesandbox-ci · 2024-06-25T06:38:39Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3e6d294:

Sandbox	Source
@keystone-6/sandbox	Configuration

gautamsi · 2024-06-25T09:34:24Z

@dcousens I will need some help in fixing tests,
* smoke tests never finishes
* wired error in package unit tests, it has mismatch on keystone error message in build but unable to trace.
* random test failure with checkForTooManyEngines prisma error

~~I have disabled some ui tests, they need fixes but we can do that before merging to main~~

@dcousens I have fixed most test cases, these tests definitely helped me fix a lot of issues.

I see that document-field test can not be fixed due to static generation, I may have missed something.

Test live-reloading.test is not behaving properly, same thing, trying to fix some page router vs app router thing. I am having trouble debugging locally on windows for some reason.

dcousens · 2024-06-25T23:20:35Z

@gautamsi I'm super busy and can't engage on this this week, but, I'll wrap back around as soon as I can and help move this forward 💛

gautamsi · 2024-06-30T12:36:03Z

@dcousens I have not generated default files for all the example/test projects, have modified the code as such it will generate all the required nextjs files for dev and build. User would need to commit them in git.

The file generation is one time except the .admin/index file which generates the admin meta has and static keystone props for admin.

gautamsi · 2024-06-30T12:43:09Z

packages/core/src/admin-ui/system/generateAdminUI.ts

  isLiveReload: boolean
 ) {
-  // when we're not doing a live reload, we want to clear everything out except the .next directory (not the .next directory because it has caches)
-  // so that at least every so often, we'll clear out anything that the deleting we do during live reloads doesn't (should just be directories)
-  if (!isLiveReload) {


This part of live reload is not needed, we do not even need to figure out file linking from main dir to isolated dir anymore

gautamsi · 2024-07-07T19:58:54Z

@dcousens do you plan to check this out soon?