-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert packages to use nominal package versions #9269
Conversation
@@ -5,6 +5,9 @@ | |||
"baseBranch": "main", | |||
"linked": [], | |||
"access": "public", | |||
"privatePackages": { | |||
"version": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This stops examples/
from generating CHANGELOG.md
and version bumps
"private": true, | ||
"author": "Dinesh Pandiyan <flexdinesh@gmail.com>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flexdinesh 💛 but we don't add this field for any of the other examples, that is what git
is for
@kennedybaird if you can follow up this work with a pull request that resolves the I think this configuration works well with |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a082e0a:
|
Alternative to #9266
Reverting #9112 and other pull requests, and seeking an alternative strategy for working with workspace package versioning.