Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pre-built schemas from create-keystone-app #9314

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Remove pre-built schemas from create-keystone-app #9314

merged 2 commits into from
Aug 30, 2024

Conversation

dcousens
Copy link
Member

@dcousens dcousens commented Aug 29, 2024

Followup to #9275, fixes #9313

This really highlights that we need to put this package under test

@keystonejs keystonejs deleted a comment from codesandbox-ci bot Aug 29, 2024
@dcousens dcousens requested a review from iamandrewluca August 29, 2024 10:50
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4d274c3:

Sandbox Source
@keystone-6/sandbox Configuration

@iamandrewluca
Copy link
Contributor

iamandrewluca commented Aug 29, 2024

@dcousens an idea

#9315

PS: Even better would be to remove the dependency install step and let the user install it themselves. 🙈

@dcousens
Copy link
Member Author

PS: Even better would be to remove the dependency install step and let the user install it themselves. 🙈

I honestly never use these workflows, what are user expectations of this in 2024?

@dcousens dcousens merged commit 616907e into main Aug 30, 2024
43 of 44 checks passed
@dcousens dcousens deleted the patch-cka branch August 30, 2024 02:14
@dcousens dcousens mentioned this pull request Aug 30, 2024
@iamandrewluca
Copy link
Contributor

iamandrewluca commented Sep 3, 2024

@dcousens

🟩 Runs npm install
🟨 Allows to choose
🟥 Does not run npm install

  • 🟩 Nuxt.js
  • 🟩 Next.js
  • 🟩 Strapi CMS
  • 🟩 Gatsby
  • 🟩 Payload CMS
  • 🟩 Angular
  • 🟩 Nest.js
  • 🟨 Remix
  • 🟨 Astro
  • 🟥 Vite
  • 🟥 Vue.js

@dcousens dcousens mentioned this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create-keystone-app ENOENT no such file or directory schema.graphql
2 participants