Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen NetInfo connectionChange event (change deprecated) #76

Merged
merged 2 commits into from Sep 13, 2017
Merged

Listen NetInfo connectionChange event (change deprecated) #76

merged 2 commits into from Sep 13, 2017

Conversation

ghost
Copy link

@ghost ghost commented Sep 4, 2017

Fixes #75

@kfiroo
Copy link
Owner

kfiroo commented Sep 4, 2017

@kytwb Great, thanks!
Just a quick question, would that cause a problem for users with lower versions of RN? (I think it's polite to support at least 1-2 previous versions)

@ghost
Copy link
Author

ghost commented Sep 4, 2017

@kfiroo I'll check and make it backward compatible if possible.
If not possible, what should I do? Follow semver and major/minor the version?

@kfiroo
Copy link
Owner

kfiroo commented Sep 4, 2017

@kytwb Thanks!
If you can't make it backward compatible we should merge it after the 1.4 version, which already forces users to upgrade

@chrusart
Copy link
Contributor

chrusart commented Sep 13, 2017

Will this work?
facebook/react-native#12503
just check if RN >= 0.48.0 then use connectionChange event name
its just a lot of warnings in console, but probably should be made in normal a way, changed in 1.4.

@kfiroo kfiroo merged commit 3d005ab into kfiroo:master Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants