Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test workflow #44

Merged
merged 4 commits into from
Aug 24, 2024
Merged

Test workflow #44

merged 4 commits into from
Aug 24, 2024

Conversation

kgaughan
Copy link
Owner

@kgaughan kgaughan commented Aug 24, 2024

Summary by Sourcery

Introduce a new GitHub Actions workflow to automate linting and testing for the project on specified Python versions.

CI:

  • Add a GitHub Actions workflow to run linting and tests on push and pull request events targeting the master branch.

Copy link
Contributor

sourcery-ai bot commented Aug 24, 2024

Reviewer's Guide by Sourcery

This pull request introduces a new GitHub Actions workflow file for running tests and linting. The workflow is set up to run on push and pull request events for the master branch, as well as manual triggers. It includes two jobs: one for linting and another for running tests across multiple Python versions.

File-Level Changes

Change Details Files
Added a new GitHub Actions workflow for testing and linting
  • Created a workflow that triggers on push and pull request events for the master branch
  • Added a manual trigger option (workflow_dispatch)
  • Implemented a lint job using Rye for formatting and linting checks
  • Implemented a test job that runs across multiple Python versions (3.8 to 3.12)
  • Used the setup-rye action to set up the Rye environment
.github/workflows/tests.yml

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kgaughan - I've reviewed your changes - here's some feedback:

Overall Comments:

  • There's an inconsistency in the versions of the setup-rye action used in the lint job (v4.2.3) and the test job (v4.2.0). Consider using the same version in both jobs to ensure consistency.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@kgaughan kgaughan merged commit 0048e61 into master Aug 24, 2024
6 checks passed
@kgaughan kgaughan deleted the test-workflow branch August 24, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant