Client login service #2678
Open
Client login service #2678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clientLoginService
…clientLoginService
noodlemoodle
changed the title
|
kgrgreer
reviewed
Apr 26, 2023
src/foam/nanos/auth/login/SignIn.js
Outdated
| required: true, | ||
| validationTextVisible: false, | ||
| label: 'Email or Username', | ||
| preSet: function(_, n) { |
There was a problem hiding this comment.
Can't you just say trim: true ?
src/foam/nanos/auth/login/SignUp.js
Outdated
| inputValidation: /\S+@\S+\.\S+/, | ||
| restrictedCharacters: /^[^\s]$/, | ||
| displayMode: foam.u2.DisplayMode.RW | ||
| }; | ||
| }, | ||
| validateObj: function(email) { | ||
| validateObj: function(email, emailAvailable) { |
There was a problem hiding this comment.
Can we make these validationPredicates instead? For all of them?
| }, | ||
| { | ||
| name: 'wizardVerifyEmail', | ||
| code: async function(x, email, username, password) { |
There was a problem hiding this comment.
Should we just use this verifyEmail flow across the board? Dont see why we need to maintain two of them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move signin signup logic to client login service