[DNM] Delegate agency scheduled task run to submit

[lchanmann]

Issues

• Since the agency scheduler/timer is single-threaded, scheduled tasks can queue up on long running task

Changes

• Delegate agency scheduled tasks run to submit to prevent the queue up
  • also prevent CompoundContextAgency from running scheduled tasks without going through execute()

Script to reproduce

import foam.nanos.logger.Loggers;

agency = x.get("threadPool");

N = 20;

for ( i = 0; i < N; i++ ) {
  final int j = i;

  agency.schedule(x, new foam.core.ContextAgent() {
    public void execute(foam.core.X x_) {
      try {
        Thread.sleep(3000 - j * 100);
      } catch ( InterruptedException e ) { }
      Loggers.logger(x_, this).debug(new Object[] { "Run task", j });
    }
  }, "agency-schedule-" + j, 4000+j*100);
}

// last
agency.schedule(x, new foam.core.ContextAgent() {
  public void execute(foam.core.X x_) {
    Loggers.logger(x_, this).debug(new Object[] {"Run agency-schedule last task"});
    throw new RuntimeException("last");
  }
}, "agency-schedule-last", 5000);


print("DONE");

[jlhughes]

Believe TaskQueue.remove now needs to be handled by the job itself when it completes.

[lchanmann]

Yes it's unchanged the TaskQueue.remove ie, TASK_QUEUE.remove(key); resides in the run() method of the job.

[jlhughes]

Will not submit return immediately?

[lchanmann]

Yes, submit on threadPool returns immediately.

[jlhughes]

Yes, submit on threadPool returns immediately.

So then, TaskQueue.remove will occur immediately, allowing concurrent same jobs.

[jlhughes]

Perhaps this should be before the run(), no guarantee that calling thread continues before the timertask.