Delete reference to removed object #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents calling a C function with an old pointer from the JS timeout callback which then crashes the GNOME Shell. An upstream fix was also sent in which prevents the crash of GNOME Shell but still this bug here needs to be fixed. Fixes kgshank#110 kgshank#108
pothos
force-pushed
the
delete-reference-directly
branch
from
39e7c1d
to
af48257
Compare
|
Thanks @pothos |
|
This doesn't remove it from the UI. It is still possible to try to select, and this will crash the shell. This is a great first step, thanks @pothos . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents calling a C function with an old pointer from the JS
timeout callback which then crashes the GNOME Shell.
An upstream fix was also sent in which prevents the crash of GNOME
Shell but still this bug here needs to be fixed.
Fixes #110 #108