Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource source data #28

Closed
wants to merge 3 commits into from
Closed

Resource source data #28

wants to merge 3 commits into from

Conversation

kaitj
Copy link
Collaborator

@kaitj kaitj commented Nov 22, 2022

Proposed changes

This PR just adds / updates necessary resource files for the workflow to run.

Note, I only added in the MNI152NLin6Asym T1w template from templateflow as we can easily go between the 2 commonly used MNI spaces and this is sufficient for getting a transformation to subject space. In the future, we can look at requiring fmriprep / adding an fmriprep as suggested during the weekly meeting.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionalitiy)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • Code has been run through the poe quality task
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

- Added tpl and updated names for MNI152NLin6Asym
- Renamed MNI2009b -> MNI152NLin2009bAsym
- Removed unnecessary files
- Update config
@kaitj kaitj added the maintenance Updates or improvements that do not change functionality of the code label Nov 22, 2022
@kaitj
Copy link
Collaborator Author

kaitj commented Nov 22, 2022

I am going to close this in favour of an upcoming PR that adds in labelmerge (see #30)

@kaitj kaitj closed this Nov 22, 2022
@kaitj kaitj deleted the resource-data branch November 22, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Updates or improvements that do not change functionality of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant