Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality (actions, pre-commit) and tests #31

Merged
merged 37 commits into from
Dec 5, 2022
Merged

Quality (actions, pre-commit) and tests #31

merged 37 commits into from
Dec 5, 2022

Commits on Nov 16, 2022

  1. Add quality workflow

    kaitj committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    6883ab0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6c76748 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c466936 View commit details
    Browse the repository at this point in the history
  4. Add types to reviewer assignment

    Will assign a reviewer when new PRs are made or when marked ready for review. Any reviews required after initial will need to be triggered by user.
    kaitj committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    8783832 View commit details
    Browse the repository at this point in the history
  5. quality fixes

    kaitj committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    cd3f7b4 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. add yamlfix pre-commit and action

    - Added opionated yaml linter to pre-commit hook and github action
      - Requires shell command to filter and exclude snakemake and snakebids
    files
    - Run yamlfix on all other yaml files
    kaitj committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    6796b9c View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2022

  1. update pyproject.toml settings

    kaitj committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    cf3c0b0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1f7dfd7 View commit details
    Browse the repository at this point in the history
  3. rm redundant flake8 ignore

    kaitj committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    5080e9e View commit details
    Browse the repository at this point in the history
  4. add fake data for testing

    - Add gitignore
    - Add bids_dir
    - Adds necessary derivatives
      - dwi is doubled to perform two different tests (one for dwi_dir flag)
      - freesurfer directories / files
    kaitj committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    cc36335 View commit details
    Browse the repository at this point in the history
  5. add testing for freesurfer

    - ensure paths passed through are absolute (exception for testing)
    - fix workflow issues
    kaitj committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    bc0eebd View commit details
    Browse the repository at this point in the history
  6. add test case for responsemean

    - add poe task for testing --responsemean_dir flag
    - fixed responsemean call (expansion over subjects)
    kaitj committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    fc9205b View commit details
    Browse the repository at this point in the history
  7. Use function to check additional dir inputs

    - Created check_dir_path function to check if user passed directories
    are absolute paths. Throw an error otherwise
    - Replace existing checks in freesurfer and mrtpipelines with function.
    kaitj committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    7892b49 View commit details
    Browse the repository at this point in the history
  8. add test case for dwi_dir flag

    - Added dwi_flag for preprocessed data
    - Added check to make sure absolute path is passed
    - Added test data within prepdwi directory for testing purposes
    kaitj committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    68eafd6 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    79e0863 View commit details
    Browse the repository at this point in the history
  10. rm debug print statement

    kaitj committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    09a80dc View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2022

  1. rm unnecessary files from test

    kaitj committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    ccfc486 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. Configuration menu
    Copy the full SHA
    6e22438 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2022

  1. Fix dwi_dir flag, add msg

    kaitj committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    4092405 View commit details
    Browse the repository at this point in the history
  2. add .gitignore

    kaitj committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    7dc5967 View commit details
    Browse the repository at this point in the history
  3. update resource files

    - Added tpl and updated names for MNI152NLin6Asym
    - Renamed MNI2009b -> MNI152NLin2009bAsym
    - Removed unnecessary files
    - Update config
    kaitj committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    4338fb3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fef07cf View commit details
    Browse the repository at this point in the history
  5. Update tsv file for labelmerge

    - Update config to include tsv for subcortical labels
    kaitj committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    ca5827f View commit details
    Browse the repository at this point in the history
  6. Update config and fs tsv

    - Update freesurfer tsv to match bids spec
    - Update file name of Freesurfer dseg tsv
    kaitj committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    94b0cb2 View commit details
    Browse the repository at this point in the history
  7. Copy zona tsv to appropriate directory

    - Add inputs to rule all for copying freesurfer and zona tsv files to
    appropriate location
    kaitj committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    4e538d5 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a19d2ed View commit details
    Browse the repository at this point in the history
  9. wip - changes for labelmerge rule

    - Still need to fix piping of workflow, update entities, and filenames
    kaitj committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    e7486d8 View commit details
    Browse the repository at this point in the history
  10. fix conflicts, update dseg

    kaitj committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    f9701ad View commit details
    Browse the repository at this point in the history
  11. add labelmerge placeholder

    - Adds in rule for labelmerge (needs updating with container and proper
    command)
    - Update resources with correct names and paths
    - Add tsv to rule all for copying from resource to bids folders for
    labelmerge
    - Simplify rule all
    kaitj committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    b458bbd View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    cda1307 View commit details
    Browse the repository at this point in the history
  13. fix FreesurferThal_dseg.tsv

    kaitj committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    0507abf View commit details
    Browse the repository at this point in the history
  14. add labelmerge container

    kaitj committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    a491fea View commit details
    Browse the repository at this point in the history
  15. snakefmt quality fixes

    kaitj committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    28acc1a View commit details
    Browse the repository at this point in the history
  16. fix column headers for tsvs

    kaitj committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    1a6a28a View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    bb0a149 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. Merge pull request #30 from kaitj/labelmerge

    Labelmerge
    tkkuehn authored Dec 5, 2022
    Configuration menu
    Copy the full SHA
    144af01 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    717fd3a View commit details
    Browse the repository at this point in the history