Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace fslmaths with python scripts #71

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Conversation

kaitj
Copy link
Collaborator

@kaitj kaitj commented Apr 26, 2023

Proposed changes

Resolves #64. Uses nibabel instead of fslmaths to perform necessary mathematical operations to create masks.
I thought about combining the two rules that called fslmaths, but ultimately decided against it (for now) to keep it simple for handling the --skip_brainstem option.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • Code has been run through the poe quality task
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

@kaitj kaitj added the maintenance Updates or improvements that do not change functionality of the code label Apr 26, 2023
Copy link
Collaborator

@tkkuehn tkkuehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me assuming you've given the scripts a try

@kaitj
Copy link
Collaborator Author

kaitj commented Apr 26, 2023

Yep, tested this and it appears to be working. Will merge this in too.

@kaitj kaitj merged commit 3909164 into khanlab:main Apr 26, 2023
@kaitj kaitj deleted the replace_fslmaths branch April 26, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Updates or improvements that do not change functionality of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace fslmaths
2 participants