Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to reusable workflow #80

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Switch to reusable workflow #80

merged 1 commit into from
Aug 24, 2023

Conversation

kaitj
Copy link
Collaborator

@kaitj kaitj commented Aug 17, 2023

Proposed changes

Switch to using reusable workflows for easier future maintenance

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • Code has been run through the poe quality task
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

@kaitj kaitj added the maintenance Updates or improvements that do not change functionality of the code label Aug 17, 2023
- Renamed deploy_docker.yml -> deploy.yml to be more generic (in case
  pypi deployment also wants to be added in the future)
- Set docker deployment reuseable wf to inherit docker auth secrets
@kaitj kaitj merged commit 10ff2d8 into khanlab:main Aug 24, 2023
4 checks passed
@kaitj kaitj deleted the maint/gh-actions branch August 24, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Updates or improvements that do not change functionality of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants