Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous bug fixes and updates #40

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Miscellaneous bug fixes and updates #40

merged 3 commits into from
Sep 28, 2023

Conversation

tkkuehn
Copy link
Contributor

@tkkuehn tkkuehn commented Sep 20, 2023 •
edited
Loading

  1. Fix the formatting of the default outtype in cfmm_base.create_key. This needs to be a tuple, but heudiconv used to silently wrap strings in a tuple. They removed that in version 0.13.0, causing cfmm_base to break.
  2. Fix a typo in the _ROI file cleanup line to add the datatype directory in datasets with sessions.
  3. Update heudiconv and dcm2niix

@tkkuehn
Make output_type a tuple
2e1d5ee 
This is a bug that heudiconv used to silently fix but doesn't anymore,
so it causes problem with new versions of heudiconv.
@tkkuehn
Update heudiconv and dcm2niix
a31df91
@tkkuehn
Handle datatype when deleting _ROI files
e681c0b
@tkkuehn tkkuehn requested a review from akhanf September 20, 2023 18:34
@akhanf akhanf merged commit 9310e5c into master Sep 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhanf akhanf akhanf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkkuehn @akhanf