Fix a lot of UI issues on Guest home page #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To free space on main navbar + less visual confusion for users who want to focus on main page functions such as food search, checking cart, login.
Also change how cart badge selection works to support multiple instances of cart badges instead of 1 (ideally there is one for <1024px and 1 for larger screens).
add: Star ratings for food cards
- Add scroll to results after performing a keyword search - Fix "Show more" button showing all food items instead of 12 per click
Searching now visually removes the active state of the selected food category button prior to the search event.
Also fix potential cart badge visual bugs
I had to revert the earlier db6d0e3 commit because it inherently broke all modals when opened from an opened modal (I don't know why). Of course, this also reverted my previous fix for the language dropdown not opening for the first click. Between the two problems however, obviously not being able to recover passwords and/or creating an account is far more serious.
Who could have thought a "show" class could do so much harm? Also fix the language button on small screens not being visually updated on translated pages.
There is a weird issue with One Tap: it still pops up even after successful login. Thankfully, it has a skip option (that only supports cookies however). As such I decided to make the default login option to use cookies instead of session (user can still choose whether to use either)
Add translation exception to "FFood"
Adding "notranslate" class to the button element itself will also disable translation for the button tooltip. That means the tooltip will display "Ngôn ngữ" regardless of selected language. Instead, I add notranslate to individual dropdown items.
...kinda, because somehow you can still do so after the first failed dragging attempt. At least the drag "preview" effect doesn't look as visible as the original effect.
- Align buttons to the actual category cards, not the entire carousel container (not 100% accurate, but looks acceptable) - Fix buttons' erratic behavior on large (992px < width < 1200px) sizes - Hide buttons on <576px width (users will have to swipe fingers) - Fix carousel not swipe-able unless user clicks its buttons at least once
tien-thanh-hua
added
bug
This was
linked to
issues
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanna sleep and there are way too many things to describe, so I'll just put up screenshots instead.
Also, screw merge conflicts I'll fix them laterQ: Where is the "Best-Selling Food" section?
A: Will be worked on after this.
Q: Both Google sign-up and sign-in buttons are not responsive!
A: It's Google's fault for not allowing relative units for width attributes. Fixing it using JS is possible, but it takes valuable time. Time that should be used for other important issues.
A picture is worth 1024 words 😃