Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sections' not matching their siblings' height #130

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

tien-thanh-hua
Copy link
Collaborator

@tien-thanh-hua tien-thanh-hua commented Nov 2, 2023

Note: PR #128 fixes a minor bug that causes entire website crash. Pls approve it first before checking this one.

Fix #117: sections' container height.
This feels... déjà vu?

image

I mean sections' container height lol
This feels... déjà vu?
@tien-thanh-hua tien-thanh-hua added bug Something isn't working frontend high priority Very important labels Nov 2, 2023
@tien-thanh-hua tien-thanh-hua added this to the Admin Dashboard milestone Nov 2, 2023
@tien-thanh-hua tien-thanh-hua self-assigned this Nov 2, 2023
@khengyun
Copy link
Owner

khengyun commented Nov 2, 2023

👋 @tien-thanh-hua
Thank you for raising your pull request.
Please make sure you have followed our contributing guidelines. We will review it as soon as possible

@khengyun khengyun merged commit 8f757e5 into main Nov 2, 2023
1 check failed
@khengyun khengyun deleted the fix/dashboard/insights/inconsistent-section-height branch November 2, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend high priority Very important
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] The admin's insight page does not have a response based on screen size.
2 participants