Skip to content
This repository has been archived by the owner on Jan 29, 2023. It is now read-only.

missing header #2

Closed
toniMephis opened this issue Mar 2, 2022 · 6 comments
Closed

missing header #2

toniMephis opened this issue Mar 2, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@toniMephis
Copy link

Arduino IDE version: 1.8.19 (Windows 1.8.57.0)
Arduino SAMD Core Version 1.8.12
ARDUINO_SAMD_MKRWIFI1010
OS: Windows10

Context:
I encountered an error while compiling SAMD_Slow_PWM.
"
In file included from ...\Arduino\libraries\SAMD_Slow_PWM\src/SAMD_Slow_PWM.h:30:0,
...\Arduino\libraries\SAMD_Slow_PWM\src/SAMD_Slow_PWM.hpp:138:10: fatal error: TimerInterrupt_Generic_Debug.h: No such file or directory
#include "TimerInterrupt_Generic_Debug.h"
compilation terminated.
"
@khoih-prog
Copy link
Owner

Hi @toniMephis

Thanks for your interest in the library and spotting my mistake in using the wrong name for the file.

To fix now, please install the SAMD_TimerInterrupt library from Arduino Library Manager

I'll release a new version to fix this issue shortly.

Regards,

@toniMephis
Copy link
Author

Ì pulled TimerInterrupt_Generic_Debug.h from repository SAMD_TimerInterrupt. It compiles now. However I slightly worry about the warnings "using SAMD hardware timer" and "CHANGING_PWM_END_OF_CYCLE == true"

@khoih-prog
Copy link
Owner

Just informational warnings for debugging purpose. Don't care about them.

@toniMephis
Copy link
Author

works perfectly. GREAT!

@toniMephis
Copy link
Author

Can you put something into an example or the readme about how to stop the PWM cleanly? Am I guessing right with detachInterrupt ???

khoih-prog added a commit that referenced this issue Mar 3, 2022
@khoih-prog
v1.2.2 to fix missing header file
9755a41 
### Releases v1.2.2

1. Use correct `PWM_Generic_Debug.h` file. Check [missing header #2](#2)
2. Display informational warning only when `_PWM_LOGLEVEL_` > 3
3. Update `Packages' Patches`
khoih-prog added a commit that referenced this issue Mar 3, 2022
@khoih-prog
v1.2.2 to fix missing header file
9d52871 
### Releases v1.2.2

1. Use correct `PWM_Generic_Debug.h` file. Check [missing header #2](#2)
2. Display informational warning only when `_PWM_LOGLEVEL_` > 3
3. Update `Packages' Patches`
khoih-prog added a commit that referenced this issue Mar 3, 2022
@khoih-prog
v1.2.2 to fix missing header file
b0229b7 
### Releases v1.2.2

1. Use correct `PWM_Generic_Debug.h` file. Check [missing header #2](#2)
2. Display informational warning only when `_PWM_LOGLEVEL_` > 3
3. Update `Packages' Patches`
@khoih-prog
Copy link
Owner

Hi @toniMephis

The new SAMD_Slow_PWM releases v1.2.2 has just been published. Your contribution is noted in Contributions and Thanks

Best Regards,

Releases v1.2.2

  1. Use correct PWM_Generic_Debug.h file. Check missing header #2
  2. Display informational warning only when _PWM_LOGLEVEL_ > 3
  3. Update Packages' Patches

@khoih-prog khoih-prog added the bug Something isn't working label Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@khoih-prog @toniMephis