Skip to content

Commit

Permalink
[Bug] Clear all the futures when sync is called. (feast-dev#501)
Browse files Browse the repository at this point in the history
* Replacing Jedis With Lettuce in ingestion and serving

* Removing extra lines

* Abstacting redis connection based on store

* Check the connection before connecting as lettuce does the retry automatically

* Running spotless

* Throw Exception if the job store config is null

* Handle No enum constant RuntimeException

* Future should be cleared everytime sync is called
  • Loading branch information
lavkesh authored and khorshuheng committed Mar 17, 2020
1 parent 2e9b93a commit ead9260
Showing 1 changed file with 5 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,11 @@ public boolean isConnected() {
public void sync() {
// Wait for some time for futures to complete
// TODO: should this be configurable?
LettuceFutures.awaitAll(60, TimeUnit.SECONDS, futures.toArray(new RedisFuture[0]));
futures.clear();
try {
LettuceFutures.awaitAll(60, TimeUnit.SECONDS, futures.toArray(new RedisFuture[0]));
} finally {
futures.clear();
}
}

@Override
Expand Down

0 comments on commit ead9260

Please sign in to comment.