Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement some best practices #118

Merged
merged 4 commits into from
Nov 23, 2021

Conversation

jmazzitelli
Copy link
Contributor

fixes kiali/kiali#4485

this first commit provides the ability to add custom labels to the Ingress/Route
@jmazzitelli jmazzitelli self-assigned this Nov 15, 2021
@jmazzitelli
Copy link
Contributor Author

jmazzitelli commented Nov 15, 2021

this first commit provides the ability to add custom labels to the Ingress/Route. It also fixes a bug I found in the Route annotations.

@jmazzitelli
Copy link
Contributor Author

jmazzitelli commented Nov 16, 2021

second commit sets the resource requests on the operator. We might also consider setting resource limits, but so far that is not implemented.

@jmazzitelli
Copy link
Contributor Author

third commit sets the resource requests on the server. We might also consider setting resource limits, but so far that is not implemented.

@jmazzitelli
Copy link
Contributor Author

fourth commit adds memory limits to the server pod. We are going to opt not to create memory limits for the operator pod right now

@jmazzitelli jmazzitelli marked this pull request as ready for review November 18, 2021 18:29
@jmazzitelli
Copy link
Contributor Author

jmazzitelli commented Nov 18, 2021

to test - install via the server helm chart and set the helm value deployment.ingress.additional_labels.foo=bar and (if on non-OpenShift/minikube/kind) set deployment.ingress.enabled=true. When you install, check that the Ingress has the label "foo: bar" and check the server pod's container to ensure it has resources defaults:

resources:
  requests:
    cpu: 10m
    memory: 64Mi
  limits;
    memory: 1Gi

If you test on OpenShift, check that the labels are on the Route (a Route is created on OpenShift, not an Ingress).

Then test by installing the operator via its helm chart and make sure it's pod container also has resources defaults:

resources:
  requests:
    cpu: 10m
    memory: 64Mi

@jmazzitelli jmazzitelli merged commit cda725c into kiali:master Nov 23, 2021
@jmazzitelli jmazzitelli deleted the 4485-best-practices branch November 23, 2021 19:19
Matiasmct pushed a commit to giffgaff/kiali-charts-backup that referenced this pull request Nov 24, 2021
* implement some best practices
fixes kiali/kiali#4485

this first commit provides the ability to add custom labels to the Ingress/Route

* set resources requests on operator deployment

* set resources requests on server deployment

* add memory limit to the server pod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[operator] implement best practice guidelines to support multi-tenant installations
2 participants