-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement some best practices #118
Conversation
fixes kiali/kiali#4485 this first commit provides the ability to add custom labels to the Ingress/Route
this first commit provides the ability to add custom labels to the Ingress/Route. It also fixes a bug I found in the Route annotations. |
830d105
to
7ca5f1b
Compare
second commit sets the resource requests on the operator. We might also consider setting resource limits, but so far that is not implemented. |
third commit sets the resource requests on the server. We might also consider setting resource limits, but so far that is not implemented. |
fourth commit adds memory limits to the server pod. We are going to opt not to create memory limits for the operator pod right now |
to test - install via the server helm chart and set the helm value resources:
requests:
cpu: 10m
memory: 64Mi
limits;
memory: 1Gi If you test on OpenShift, check that the labels are on the Route (a Route is created on OpenShift, not an Ingress). Then test by installing the operator via its helm chart and make sure it's pod container also has resources defaults: resources:
requests:
cpu: 10m
memory: 64Mi |
* implement some best practices fixes kiali/kiali#4485 this first commit provides the ability to add custom labels to the Ingress/Route * set resources requests on operator deployment * set resources requests on server deployment * add memory limit to the server pod
fixes kiali/kiali#4485