Fix for Apple MacOS M1 #176
Conversation
| @@ -18,7 +18,7 @@ HELM_IMAGE_REPO_SERVER ?= quay.io/kiali/kiali | |||
| DORP ?= docker | |||
|
|
|||
| # When building the helm chart, this is the helm version to use | |||
| HELM_VERSION ?= v3.5.2 | |||
| HELM_VERSION ?= v3.10.1 | |||
There was a problem hiding this comment.
is this bump of helm required for ARM support? If not, it would not be related to this issue and so should not be included.
There was a problem hiding this comment.
Yeah it is, as ARM support started from 3.6.0. and if to bump it, why not to bump to the latest.
Let me know what do you think
|
Please create a Kiali issue and associate it with this PR (i.e. put Putting on a DNM label until we get an issue for this PR. |
Thank you for the comments. Created an issue and associated it with this PR |
|
Works on my machine. Confirmed it pulls down helm 3.10.1, and the build-helm-charts target still works. Nothing breaks. I don't have an ARM machine to test, but I assume that will work since that's the whole point :) I did confirm this is a valid URL and what the make target will attempt to download: https://get.helm.sh/helm-v3.10.1-darwin-arm64.tar.gz |
fixes: kiali/kiali#5580