Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git config back #246

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Add git config back #246

merged 1 commit into from
Feb 12, 2024

Conversation

leandroberetta
Copy link
Contributor

We need to add some git configuration back into the pipeline because is required to push or create tags. Current releases failed because of this: https://github.com/kiali/helm-charts/actions/runs/7868923370

For reference, this is the PR that made the change: #243

For now, until we investigate a way of removing this configuration, we will need it for release.

Copy link
Contributor

@josunect josunect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 2FA should not be affected for this?

LGTM

@leandroberetta leandroberetta merged commit 64026f8 into kiali:master Feb 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants