[helm] set app.kubernetes.io/instance label appropriately, define the new deployment.instance_name value #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
However, for backward compat, use fullnameOverride if non-kiali but instance_name is. Change labels to be consistent with the way the operator sets them. The app.kubernetes.io/instance is the instance name of this install with app.kuberentes.io/name fixed as "kiali".
|
This is a companion to kiali/kiali-operator#313 I did a quick test and this works. |
|
To test - install via helm by passing in |
mattmahoneyrh
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: kiali/kiali#4018
This only touches the kiali-server helm chart.
If you leave all defaults as-is, this works as before and you will not notice any differences. The only difference is if you want to set
fullnameOverride.To simulate the way the operator works, the kiali-server helm chart now uses
deployment.instance_namerather than the now-deprecatedfullnameOverride. For backwards compatibility, iffullnameOverrideis notkialibutdeployment.instance_nameremains its default value ofkiali, thenfullnameOverrideis used, otherwisedeployment.instance_nameis used. The oldnameOverrideis deprecated and now ignored.A second commit in this PR merely removes the quotes from the dashboard apiVersion fields for consistency to all other resources.