Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide the ability to disable features #507

Merged
merged 2 commits into from
Mar 31, 2022
Merged

provide the ability to disable features #507

merged 2 commits into from
Mar 31, 2022

Conversation

jmazzitelli
Copy link
Contributor

@jmazzitelli jmazzitelli commented Mar 23, 2022 •
edited
Loading

part of: kiali/kiali#4737

server PR: kiali/kiali#4839
operator PR: #507
helm PR: kiali/helm-charts#130

@jmazzitelli jmazzitelli self-assigned this Mar 23, 2022
@jmazzitelli jmazzitelli force-pushed the 4737-disable-features branch from 3b43ebf to c56cf23 Compare March 23, 2022 20:38
This was referenced Mar 23, 2022
Merged
Merged
@jmazzitelli jmazzitelli mentioned this pull request Mar 23, 2022
Closed
@jmazzitelli jmazzitelli force-pushed the 4737-disable-features branch from c56cf23 to f9a0c77 Compare March 24, 2022 01:50
@jmazzitelli
Copy link
Contributor Author

jmazzitelli commented Mar 24, 2022 •
edited
Loading

This PR adds a new test in the cluster-values-test molecule scenario - run it to confirm it passes:

make \
   -e HELM_CHARTS_REPO_PULL=false \
   -e CLUSTER_TYPE=minikube \
   -e MOLECULE_SCENARIO="config-values-test" \
   -e MOLECULE_USE_DEV_IMAGES="true" \
   -e MOLECULE_DUMP_LOGS_ON_ERROR=false \
   clean build cluster-push molecule-test

@jmazzitelli jmazzitelli force-pushed the 4737-disable-features branch from f9a0c77 to cd7b56d Compare March 24, 2022 02:00
@jmazzitelli jmazzitelli marked this pull request as ready for review March 24, 2022 20:24
@lucasponce lucasponce self-requested a review March 31, 2022 09:37
@jmazzitelli jmazzitelli merged commit 02d8f85 into kiali:master Mar 31, 2022
@jmazzitelli jmazzitelli deleted the 4737-disable-features branch March 31, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasponce lucasponce lucasponce approved these changes

Assignees

@jmazzitelli jmazzitelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmazzitelli @lucasponce