Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

WIP POC Jaeger Embedded components #736

Closed
wants to merge 1 commit into from

Conversation

aljesusg
Copy link
Contributor

@aljesusg aljesusg commented Oct 8, 2018

Just a Poc

From the PoC embed components in jaeger jaegertracing/jaeger-ui#263

Distribute tracing link

We should have here or own search for the traces
resukts

Traces of a service

resutls2

On trace

trace_vire

Video Show

poc kiali

cc @lucasponce

@lucasponce lucasponce added the do not merge A PR is not ready to merge label Oct 8, 2018
@rhqci
Copy link

rhqci commented Oct 8, 2018

✔️ Jenkins CI: kiali-ui-pr-e2e-test #180

KIALI_NAME=kialiuipr736-istio-system

@@ -28,10 +28,14 @@ const EmptyStatePage = () => (
class ServiceJaegerPage extends React.Component<RouteComponentProps<{}>, ServiceJaegerState> {
constructor(props: RouteComponentProps<{}>) {
super(props);
this.state = { jaegerURL: '', error: false };
this.state = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the jaegerURL really stateful? Do we switch jaegerURLs in the application and expect a render?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No @mtho11, this will be like before we request to the backend for the Jaeger url, this is a PoC

@rhqci
Copy link

rhqci commented Oct 9, 2018

✔️ Jenkins CI: kiali-ui-pr-e2e-test #189

KIALI_NAME=kialiuipr736-istio-system

@aljesusg aljesusg changed the title WIP POC Jaeger Embed componentes WIP POC Jaeger Embed components Oct 9, 2018
@aljesusg aljesusg changed the title WIP POC Jaeger Embed components WIP POC Jaeger Embedded components Oct 9, 2018
@clyang82
Copy link
Contributor

@aljesusg I saw there has a ticket to move iframe to external links - #619. Right now, it seems you are working on using iframe to embed the jaeger again. What is the reason to use iframe? Thanks.

@lucasponce
Copy link
Contributor

Hi @clyang82,

The main JIRA explaining the brackground of this work is under this link https://issues.jboss.org/browse/KIALI-1406.

Basically Kiali's goal is to offer added value integration with Jaeger.
In our first step we integrated in the app as an iFrame, but it didn't offer high integration, only a minimal filtering, also it had some issues working with an embedded proxy.

That was the main motivation to move Jaeger as an external link until we have progress in a consistent integration.

@aljesusg is working with the Jaeger community to allow to consume the UI in a better component driven jaegertracing/jaeger-ui#248 then we can integrate it with Kiali sharing filtering as same time interval used for collect metrics and traces.

@clyang82
Copy link
Contributor

clyang82 commented Oct 15, 2018

@lucasponce Thanks for your response. If I am not mistaken the consistent integration is not an iframe, jaeger-ui will be a component which can be included as a standard component by react app. That's great idea.

@lucasponce
Copy link
Contributor

@clyang82 yes, if you follow the Jaeger UI discussion, main developers want to follow a similiar Google API approach (talking about the implementation of this approach) but the idea behind it is to reuse Jaeger in a standard way (so not discarded that an iframe is part of the implementation after all).
Also our plans are to collaborate more closely with the Jaeger community, so any changes proposed will be consolidated in a standard way.

@clyang82
Copy link
Contributor

@lucasponce I vote this enhancement. What is the plan to deliver this feature?

@lucasponce
Copy link
Contributor

@clyang82 on this Sprint 12, @aljesusg is mainly focus to research and be in contact with the Jaeger community about this feature.
There are some PRs to start moving Jaeger UI as a component, once those are consolidated, in following sprints we will propagate these changes in Kiali.
Also there are some multitenancy/security aspects related that are WIP, but Jaeger integration is top priority for Kiali, so count we will be working on that direction on this and next sprints.

@aljesusg aljesusg closed this Dec 4, 2018
@aljesusg aljesusg deleted the jaeger_poc branch December 4, 2018 16:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
do not merge A PR is not ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants