-
Notifications
You must be signed in to change notification settings - Fork 115
Conversation
@@ -28,10 +28,14 @@ const EmptyStatePage = () => ( | |||
class ServiceJaegerPage extends React.Component<RouteComponentProps<{}>, ServiceJaegerState> { | |||
constructor(props: RouteComponentProps<{}>) { | |||
super(props); | |||
this.state = { jaegerURL: '', error: false }; | |||
this.state = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the jaegerURL really stateful? Do we switch jaegerURLs in the application and expect a render?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No @mtho11, this will be like before we request to the backend for the Jaeger url, this is a PoC
Hi @clyang82, The main JIRA explaining the brackground of this work is under this link https://issues.jboss.org/browse/KIALI-1406. Basically Kiali's goal is to offer added value integration with Jaeger. That was the main motivation to move Jaeger as an external link until we have progress in a consistent integration. @aljesusg is working with the Jaeger community to allow to consume the UI in a better component driven jaegertracing/jaeger-ui#248 then we can integrate it with Kiali sharing filtering as same time interval used for collect metrics and traces. |
@lucasponce Thanks for your response. If I am not mistaken the consistent integration is not an iframe, jaeger-ui will be a component which can be included as a standard component by react app. That's great idea. |
@clyang82 yes, if you follow the Jaeger UI discussion, main developers want to follow a similiar Google API approach (talking about the implementation of this approach) but the idea behind it is to reuse Jaeger in a standard way (so not discarded that an iframe is part of the implementation after all). |
@lucasponce I vote this enhancement. What is the plan to deliver this feature? |
@clyang82 on this Sprint 12, @aljesusg is mainly focus to research and be in contact with the Jaeger community about this feature. |
Just a Poc
From the PoC embed components in jaeger jaegertracing/jaeger-ui#263
Distribute tracing link
We should have here or own search for the traces
Traces of a service
On trace
Video Show
cc @lucasponce