Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kiali and Ambient features page #799

Merged
merged 14 commits into from
Jul 4, 2024
Merged

Kiali and Ambient features page #799

merged 14 commits into from
Jul 4, 2024

Conversation

josunect
Copy link
Contributor

@josunect josunect commented Jul 2, 2024 •
edited by jshaughn
Loading

Closes kiali/kiali#7490

Add a new Kiali page indicating the Ambient visualizations

https://deploy-preview-799--kiali.netlify.app/docs/features/ambient/

@josunect josunect added the enhancement New feature or request label Jul 2, 2024
@josunect josunect self-assigned this Jul 2, 2024
@josunect josunect requested a review from jshaughn July 2, 2024 07:49
jshaughn
jshaughn requested changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @josunect. Thanks for all of the screenshots! I tied this PR to the existing issue. I made a few suggestions, mainly changing label terminology to badge, so as not to overload the k8s label term. In the issue it also mentions, "status". I wasn't sure if there was anything to add around status.

content/en/docs/Features/ambient.md Outdated Show resolved Hide resolved
content/en/docs/Features/ambient.md Outdated Show resolved Hide resolved
content/en/docs/Features/ambient.md Outdated Show resolved Hide resolved
content/en/docs/Features/ambient.md Outdated Show resolved Hide resolved
content/en/docs/Features/ambient.md Outdated Show resolved Hide resolved
content/en/docs/Features/ambient.md Outdated Show resolved Hide resolved
content/en/docs/Features/ambient.md Outdated Show resolved Hide resolved
content/en/docs/Features/ambient.md Outdated Show resolved Hide resolved
josunect and others added 8 commits July 4, 2024 08:01
@josunect @jshaughn
Update content/en/docs/Features/ambient.md
75f1037 
Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com>
@josunect @jshaughn
Update content/en/docs/Features/ambient.md
3282e02 
Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com>
@josunect @jshaughn
Update content/en/docs/Features/ambient.md
b11d5b6 
Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com>
@josunect @jshaughn
Update content/en/docs/Features/ambient.md
b87cd8f 
Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com>
@josunect @jshaughn
Update content/en/docs/Features/ambient.md
c977fa8 
Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com>
@josunect @jshaughn
Update content/en/docs/Features/ambient.md
9bf1a31 
Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com>
@josunect @jshaughn
Update content/en/docs/Features/ambient.md
f2cf551 
Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com>
@josunect @jshaughn
Update content/en/docs/Features/ambient.md
ea958d4 
Co-authored-by: Jay Shaughnessy <jshaughn@redhat.com>
@josunect
Copy link
Contributor Author

josunect commented Jul 4, 2024 •
edited
Loading

Looks good, @josunect. Thanks for all of the screenshots! I tied this PR to the existing issue. I made a few suggestions, mainly changing label terminology to badge, so as not to overload the k8s label term. In the issue it also mentions, "status". I wasn't sure if there was anything to add around status.

Thanks for the review, @jshaughn !
Regarding the status, I've just added it as a warning in the beginning, so it is more visible:

image

The other comments have been addressed.

@josunect josunect requested a review from jshaughn July 4, 2024 12:50
jshaughn
jshaughn approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@josunect josunect merged commit 9e37ef6 into kiali:staging Jul 4, 2024
4 of 5 checks passed
@josunect josunect deleted the ambient_features branch July 4, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshaughn jshaughn jshaughn approved these changes

Assignees

@josunect josunect

Labels
enhancement New feature or request
Projects
Kiali Sprint 24-12 | Kiali v1.89.x
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Kiali and Ambient documentation
2 participants
@josunect @jshaughn