-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI messages at INFO level look just like ERROR level messages #4871
Labels
bug
Something isn't working
Comments
This looks like a 3-line fix - I might just put this in my other PR #4839 that introduces our first INFO message (which is how I saw this bug): diff --git a/frontend/src/components/MessageCenter/NotificationList.tsx b/frontend/src/components/MessageCenter/NotificationList.tsx
index 5d68c0519..be40dd95e 100644
--- a/frontend/src/components/MessageCenter/NotificationList.tsx
+++ b/frontend/src/components/MessageCenter/NotificationList.tsx
@@ -21,6 +21,9 @@ export default class NotificationList extends React.PureComponent<NotificationLi
case MessageType.WARNING:
variant = AlertVariant.warning;
break;
+ case MessageType.INFO:
+ variant = AlertVariant.info;
+ break;
default:
variant = AlertVariant.danger;
} |
jmazzitelli
added a commit
to jmazzitelli/kiali
that referenced
this issue
Mar 29, 2022
jmazzitelli
added a commit
that referenced
this issue
Mar 31, 2022
* provide the ability to disable features part of: #4737 * changing feature name to logs-tab * if things are disabled, add message at login * UI notification of disabled features * fix the INFO notification color and icon. fixes: #4871 * hide the popup notification * fail fast if the feature name is invalid.
yzzeee
pushed a commit
to yzzeee/kiali
that referenced
this issue
Jul 10, 2023
* provide the ability to disable features part of: kiali/kiali#4737 * changing feature name to logs-tab * if things are disabled, add message at login * UI notification of disabled features * fix the INFO notification color and icon. fixes: kiali/kiali#4871 * hide the popup notification * fail fast if the feature name is invalid.
yzzeee
pushed a commit
to yzzeee/kiali
that referenced
this issue
Jul 10, 2023
* provide the ability to disable features part of: kiali/kiali#4737 * changing feature name to logs-tab * if things are disabled, add message at login * UI notification of disabled features * fix the INFO notification color and icon. fixes: kiali/kiali#4871 * hide the popup notification * fail fast if the feature name is invalid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I don't think INFO level messages should look like ERROR messages (color red with same icon).
The text was updated successfully, but these errors were encountered: