Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Closed Caption #36

Closed
xaudiblex opened this issue Jul 30, 2016 · 6 comments
Closed

Support Closed Caption #36

xaudiblex opened this issue Jul 30, 2016 · 6 comments

Comments

@xaudiblex
Copy link

xaudiblex commented Jul 30, 2016

Now that we are able to do pass through, would it be possible to look into closed caption support?

@kiall
Copy link
Owner

kiall commented Aug 7, 2016

Absolutely, CC's are defiantly something we can and will support. Priority #1 right now is getting moved to HTSP, after we do, more features will start showing up :)

@kiall
Copy link
Owner

kiall commented Dec 28, 2016

The ExoPlayer2 session type now supports subtitles, but ExoPlayer does not yet support DVBSUB format subtitles - which means a good 99% of subs this app receives won't work..

There's WIP over at google/ExoPlayer#1781 to add support for DVBSUB to ExoPlayer, hopefully this lands soon..

@xaudiblex
Copy link
Author

xaudiblex commented Dec 28, 2016 via email

@kiall
Copy link
Owner

kiall commented Dec 28, 2016

@xaudiblex That depends, what codec does US ATSC use for subtitles? If you open TVHeadend, browse to Config -> DVB Inputs -> Services, find a channel with subtitles, and hit the little "i" button detailing the codecs in use.

Something like this:
image

@xaudiblex
Copy link
Author

xaudiblex commented Dec 29, 2016 via email

@kiall
Copy link
Owner

kiall commented Jan 3, 2017

Fixed in v0.1.66 on ExoPlayer session - ExoPlayer will soon become the only session choice, and this won't be implemented on the MediaPlayer or VLC session types. If there are specific issues with this feature on ExoPlayer, using a MKV stream profile, on v0.1.66, please open a new bug.

(I'm aware DVBSUB does not work, and will open a new bug to track)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants