Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve dmverity-vhd -d performance (microsoft#2089)
The current implementation of dmverity-vhd -d has to make one of the following tradeoffs: Runtime: By default this option calls the docker daemon to fetch the entire image for each layer as it doesn't provide an endpoint to get a specific layer Memory: The user can include a -b option that makes this call buffered, keeping the image in memory the whole time, this is much faster but at the cost of keeping the whole image in memory, which is a problem with runners with low memory microsoft#2086 Proposed a new tradeoff of disk space, by saving the image to disk and accessing the layers locally, this is a problem for runners with smaller disks as the image is stored twice. This solution makes a single request to the docker daemon, and processes both the layer hashes and the manifest to assign layer numbers in a single pass, making it performant in all three aspects. --------- Signed-off-by: Dominic Ayre <dominicayre@microsoft.com> Signed-off-by: Dominic Ayre <domayre@outlook.com>
- Loading branch information