MLB -1798: Added plot selected badge to PledgeItemizedDetails #2166
+119
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added plotSelected prop, created component, added tests and added previews
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2166 +/- ##
============================================
- Coverage 68.89% 68.86% -0.03%
+ Complexity 2225 2224 -1
============================================
Files 366 366
Lines 23100 23152 +52
Branches 3349 3356 +7
============================================
+ Hits 15915 15944 +29
- Misses 5375 5396 +21
- Partials 1810 1812 +2 ☔ View full report in Codecov by Sentry. |
| @@ -101,7 +128,8 @@ fun ItemizedRewardListContainer( | |||
| totalBonusSupport: String, | |||
| deliveryDateString: String = "", | |||
| rewardsHaveShippables: Boolean = false, | |||
| disclaimerText: String = "" | |||
| disclaimerText: String = "", | |||
| plotSelected: Boolean | |||
There was a problem hiding this comment.
We can pass in a default value of false here for plotSelected, and then it will only show when we pass in a true value. that way we aren't required to pass in a value for this field everywhere we call this function unless it's PLOT related
| ) | ||
| } | ||
| } | ||
| deliveryDate.assertIsDisplayed() | ||
| deliveryDate.assertTextEquals("April 10") | ||
| } | ||
|
|
||
| @Test | ||
| fun `test plot selected, when plot selected should show plot selected badge`() { |
leighdouglas
previously approved these changes
Nov 13, 2024
Arkariang
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Created PLOT badge on PledgeItemizedDetails
🤔 Why
To indicates when PLOT is selected.
🛠 How
added plotSelected prop, created component, added tests and added previews
👀 See