feat: SKFP-1127 bump dep, fix lint issues and use config instead of h…

…ardcoded index name

.env schema

@@ -12,4 +12,7 @@ KEYCLOAK_REALM=
 KEYCLOAK_CLIENT=
 
 # Riff 
-RIFF_URL=
+RIFF_URL=
+
+# Indexs name
+ES_BIOSPECIMEN_INDEX=

.eslintrc

@@ -10,9 +10,11 @@
         "sourceType": "module"
     },
     "plugins": [
+        "@typescript-eslint",
         "simple-import-sort"
     ],
     "extends": [
+        "eslint:recommended",
         "plugin:@typescript-eslint/recommended", 
         "plugin:prettier/recommended"
     ],
@@ -29,12 +31,13 @@
                 "ignoreComments": true
             }
         ],
-        "no-console": ["error", { "allow": ["warn", "error"] }],
+        "no-explicit-any": "off",
+        "@typescript-eslint/no-explicit-any": "off",
+        "no-console": ["error", { "allow": ["warn", "error", "time", "timeEnd", "assert"] }],
         "no-unused-vars": "off",
         "@typescript-eslint/no-unused-vars": ["warn", { "argsIgnorePattern": "^_" }],
         "prefer-spread": "error",
         "prettier/prettier": ["error"],
         "simple-import-sort/imports": "error"
     }
 }
-

.github/workflows/check_pull_request.yml

@@ -0,0 +1,26 @@
+name: Check Pull Request Quality
+
+on:
+  pull_request:
+    branches: [master]
+
+jobs:
+  tests:
+    name: Run Tests
+    runs-on: ubuntu-22.04
+    steps:
+      - name: Checkout Source Code
+        uses: actions/checkout@v3
+      - name: Setup node
+        uses: actions/setup-node@v3
+        with:
+            node-version: 18
+      - name: Use Dependencies Cache
+        uses: actions/cache@v3
+        with:
+          path: '**/node_modules'
+          key: ${{ runner.os }}-modules-${{ hashFiles('**/package-lock.json') }}
+      - name: Install Dependencies
+        run: npm ci
+      - name: Run tests and coverage
+        run: npm run test:coverage

Dockerfile

@@ -2,14 +2,13 @@
 FROM node:20-alpine3.18 AS build-image
 WORKDIR /app
 COPY . .
-RUN npm ci
-RUN npm run clean
-RUN npm run build
+RUN npm ci && npm run clean && npm run build && npm run test:silent
 
 # Second image, that creates an image for production
 FROM node:20-alpine3.18 AS prod-image
 WORKDIR /app
 COPY --from=build-image ./app/dist ./dist
 COPY package* ./
-RUN npm ci --production
-CMD [ "node", "./dist/src/index.js" ]
+RUN apk update && apk upgrade --no-cache libcrypto3 libssl3 && npm ci --production
+ENV NODE_ENV=production
+CMD [ "node", "./dist/src/index.js" ]

jest.config.js

@@ -1,14 +1,17 @@
 module.exports = {
-    globals: {
-        'ts-jest': {
-            tsconfig: 'tsconfig.json',
-        },
-    },
     moduleFileExtensions: ['ts', 'js'],
     transform: {
-        '^.+\\.(ts|tsx)$': 'ts-jest',
+        '^.+\\.(ts|tsx)$': [
+            'ts-jest',
+            {
+                tsconfig: 'tsconfig.json',
+            },
+        ],
     },
     testMatch: ['**/src/**/*.test.(ts|js)'],
     testEnvironment: 'node',
     modulePathIgnorePatterns: ['<rootDir>/dist/'],
+    collectCoverage: true,
+    collectCoverageFrom: ['src/**/*.ts'],
+    coverageDirectory: '<rootDir>/coverage/',
 };

nodemon.json

@@ -0,0 +1,6 @@
+{
+    "ignore": ["**/*.test.ts", "**/*.spec.ts", "node_modules"],
+    "watch": ["src"],
+    "exec": "npm start",
+    "ext": "ts"
+}