Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature(cohortBuilder): add saveSet Button #2465

Closed
evans-g-crsj opened this issue Apr 28, 2020 · 0 comments
Closed

Feature(cohortBuilder): add saveSet Button #2465

evans-g-crsj opened this issue Apr 28, 2020 · 0 comments
Assignees
@adipaul1981 @evans-g-crsj
Labels
Feature [Type] New feature or request

Comments

@evans-g-crsj
Copy link
Contributor

We must allow the user to save a given set (set of participants for a given query).

This set will be used by the variant db interface.

  • Add a button 'save participant set' in the table view of the cohort builder;

  • When the button is clicked a modal must be displayed and invite the user to add a name for it's saveSet.

screenshotSaveSetButtonEmplacement.png
@evans-g-crsj evans-g-crsj added Feature [Type] New feature or request ui labels Apr 28, 2020
evans-g-crsj added a commit to evans-g-crsj/kf-portal-ui that referenced this issue Apr 30, 2020
@evans-g-crsj
Feature(CohortBuilder Table View): kids-first#2465 add button and mod…
beb931a 
…al for saving a set
evans-g-crsj added a commit that referenced this issue Apr 30, 2020
@evans-g-crsj
2465 add saveset button modal to cohort (#2471)
363bf8c 
* Refactor(CohortBuilder Table View, File View): improve layout + use Antd whenever possible + Make sure export loader doesn't break layout (I had to refactor Export.js) + PropTypes

* Feature(CohortBuilder Table View): #2465 add button and modal for saving a set

* Style(Ontology Browser): corrected merge conflict

* Style(Ontology Browser): corrected merge conflict

* test(Selection tree): fix test broken because of prettier.

* Refactor(DownloadButton, ParticipantTableView.css): use one-liner + avoid code repeat in css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adipaul1981 adipaul1981

@evans-g-crsj evans-g-crsj

Labels
Feature [Type] New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adipaul1981 @evans-g-crsj