Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cohort builder, save sets modal, file repository link): improve ui #2568

Closed
3 tasks done
evans-g-crsj opened this issue Jun 16, 2020 · 4 comments
Closed
3 tasks done

refactor(cohort builder, save sets modal, file repository link): improve ui #2568

evans-g-crsj opened this issue Jun 16, 2020 · 4 comments
Assignees
@evans-g-crsj
Labels
Feature [Type] New feature or request

Comments

@evans-g-crsj
Copy link
Contributor

evans-g-crsj commented Jun 16, 2020 •
edited
Loading

  • Make the link to the file repository more intuitive
  • Make sure that the input is focused when opening the save sets modal

Defects

  • The Cohort Results info are not aligned with the text inside the button.

Resources

Screen Shot 2020-06-23 at 2 58 52 PM
@evans-g-crsj evans-g-crsj added Feature [Type] New feature or request UI labels Jun 16, 2020
@evans-g-crsj evans-g-crsj self-assigned this Jun 16, 2020
@evans-g-crsj
Copy link
Contributor Author

screenshots:

screenshotSaveSetModalAutofocus

screenshotFileRepoButtonLink

@evans-g-crsj evans-g-crsj mentioned this issue Jun 16, 2020
Merged
@denis-crsj
Copy link
Contributor

@evans-g-crsj 1 defect found. I modified the the description and added the defect with a screenshot. Putting the task back to "In progress"

evans-g-crsj added a commit to evans-g-crsj/kf-portal-ui that referenced this issue Jun 24, 2020
@evans-g-crsj
fix(css): kids-first#2568 centre align results
2aa9301
evans-g-crsj added a commit that referenced this issue Jun 24, 2020
@evans-g-crsj
fix(css): #2568 centre align results (#2575)
fc027f7 
I bypass reviewers since no one is available at this point in time.
@evans-g-crsj
Copy link
Contributor Author

@denis-crsj fix merged in qa

@denis-crsj
Copy link
Contributor

All defects fixed. Tested in Chrome and Firefox. Moving the task to Done.

@denis-crsj denis-crsj mentioned this issue Jul 7, 2020
Closed
@denis-crsj denis-crsj mentioned this issue Oct 5, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evans-g-crsj evans-g-crsj

Labels
Feature [Type] New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evans-g-crsj @denis-crsj