Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor du Summary/table view #2633

Closed
4 of 5 tasks
denis-crsj opened this issue Aug 4, 2020 · 7 comments
Closed
4 of 5 tasks

Refactor du Summary/table view #2633

denis-crsj opened this issue Aug 4, 2020 · 7 comments
Assignees
Milestone

Comments

@denis-crsj
Copy link
Contributor

denis-crsj commented Aug 4, 2020

Maquettes 👇

https://www.figma.com/file/xwFNKpa1zXoCg1xaJhAvKn/KF---Saved-Sets?node-id=18%3A56&viewport=1499%2C774%2C0.6173954606056213

Defects

  • Espace blanc trop grand en haut des boutons "Columns" et "Export"
  • Dans la barre "Query 1 ...", le texte et les petits icône ne semblent pas être de la bonne couleur
  • L'icône de la flêche à côté du nombre de fichier devrait être souligné également
  • Les bouton "Export" et "Download" ne devrait pas avoir de bordure - c'est le bouton style ant-btn-link small
  • L'icône du bouton "Column" doit être changé et déplacé à gauche du texte

image

image

@denis-crsj denis-crsj added this to the Sprint 20-02 milestone Aug 7, 2020
@denis-crsj denis-crsj modified the milestones: Sprint 20-02, Sprint 20-03 Aug 24, 2020
@francisl francisl self-assigned this Aug 25, 2020
francisl added a commit to francisl/kf-portal-ui that referenced this issue Sep 9, 2020
francisl added a commit to francisl/kf-portal-ui that referenced this issue Sep 9, 2020
francisl added a commit to francisl/kf-portal-ui that referenced this issue Sep 10, 2020
francisl added a commit to francisl/kf-portal-ui that referenced this issue Sep 10, 2020
francisl added a commit to francisl/kf-portal-ui that referenced this issue Sep 10, 2020
francisl added a commit that referenced this issue Sep 10, 2020
@denis-crsj
Copy link
Contributor Author

Only the section regarding the tabs will be deployed and another story will be created for the portion with the buttons.

@denis-crsj
Copy link
Contributor Author

Tested successfully on Chrome and Firefox

@denis-crsj
Copy link
Contributor Author

@francisl Salut Francis, J'ai ajouté les petits points à corriger dans la description en haut avec un imprime écran. Laisse-moi savoir si tu as des questions !

@francisl
Copy link
Contributor

@luclemo about the second point. It's not from a font icon library, default antd or svg. they are not customizable.

@denis-crsj please create a new design ticket to provide the proper format, so we can theme the icons.

@luclemo
Copy link

luclemo commented Sep 22, 2020

@francisl Ok pas de soucis, si on les embed directement plutôt q'un img source ça devrait être plus flexible. J'ai les SVG si @denis-crsj veut les ajouter au nouveau ticket.

@luclemo
Copy link

luclemo commented Sep 22, 2020

L'icône de la flêche à côté du nombre de fichier devrait être souligné également

@francisl @denis-crsj Désolé j'avais pas vue ça passer. Si tu a déjas apporté la correction tant mieux, sinon tu peux laisser faire ça.

francisl added a commit to francisl/kf-portal-ui that referenced this issue Sep 22, 2020
@luclemo
Copy link

luclemo commented Sep 22, 2020

@francisl voici les icônes en fichiers svg individuels et aussi un sprite suivant ce que tu préfère pour les intégrer:

kf-icons.zip

EDIT:

New zip just with individual icons: kf-icons-single.zip

francisl added a commit to francisl/kf-portal-ui that referenced this issue Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants