Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA- Comments on sets #2755

Closed
adipaul1981 opened this issue Sep 30, 2020 · 1 comment
Closed

QA- Comments on sets #2755

adipaul1981 opened this issue Sep 30, 2020 · 1 comment
Milestone
Sprint 20-05

Comments

@adipaul1981
Copy link
Contributor

adipaul1981 commented Sep 30, 2020 •
edited
Loading

  1. remove Sets from the kf-investigator group restriction.
  2. add set in cohort builder should override if an existing set is present.
@adipaul1981 adipaul1981 changed the title QA- Comments QA- Comments on sets Sep 30, 2020
adipaul1981 added a commit to adipaul1981/kf-portal-ui that referenced this issue Oct 1, 2020
@adipaul1981
fix(Sets): kids-first#2755 remove group filter on sets and override s…
c27918a 
…ets in ch b.
adipaul1981 added a commit to adipaul1981/kf-portal-ui that referenced this issue Oct 1, 2020
@adipaul1981
fix(Sets): kids-first#2755 remove group filter on sets and override s…
5471f12 
…ets in ch b.
adipaul1981 added a commit to adipaul1981/kf-portal-ui that referenced this issue Oct 1, 2020
@adipaul1981
fix(Sets): kids-first#2755 fix tests
e6b2b44
adipaul1981 added a commit that referenced this issue Oct 1, 2020
@adipaul1981
Fix/2755 qa comments (#2761)
2fccb34 
* fix(Sets): #2755 remove group filter on sets and override sets in ch b.

* fix(Sets): #2755 fix tests
@denis-crsj denis-crsj added this to the Sprint 20-05 milestone Oct 1, 2020
@denis-crsj
Copy link
Contributor

Tested and deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 20-05
Development

No branches or pull requests
2 participants
@adipaul1981 @denis-crsj