fixed #2020 (mondo link) + added vs-code suggested extensions. #2036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w bug => removed duplicate links in the very same column + extracted (some) css in an external file + added some props in an explict way instead of doing the evil {...props}
|
To Summarize,
|
src/components/CohortBuilder/ParticipantsTableView/ParticipantsTable.js
Outdated
Show resolved
Hide resolved
src/components/CohortBuilder/ParticipantsTableView/ParticipantsTable.js
Outdated
Show resolved
Hide resolved
…toring at the same time.
…toring at the same time (part 2 of 2).
nyanofthemoon
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was asked is done but there are a few things I would like to to do to clean some things up.
Such as:
extract css in an external file
remove some of the {...props}
multiple links are not correctly aligned
test NCITLINK (regex could potentially be improved to avoid an extra manipulation)