Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProcessInstanceInfo set start date when constructed #1705

Merged
merged 7 commits into from
Aug 4, 2020
Merged

ProcessInstanceInfo set start date when constructed #1705

merged 7 commits into from
Aug 4, 2020

Commits on Jul 22, 2020

  1. ProcessInstanceInfo set start date when constructed 

    In the `PrometheusProcessEventListener`, the field `startDate` from a `processInstance` is used to time the process instance duration metric.
https://github.com/kiegroup/droolsjbpm-integration/blob/4fb9e4c239dfc21ea99ea5b701877cafeafcbe1d/kie-server-parent/kie-server-services/kie-server-services-prometheus/src/main/java/org/kie/server/services/prometheus/PrometheusProcessEventListener.java#L96

However, the start date was always null because it is being set when `getProcessInstance` is first called.
Since `getProcessInstance` is not called before we trigger the event listener, the start date was never set.
The `ProcessInstance` start date should be set when the `ProcessInstanceInfo` object is first created.
    @hmatt1
    hmatt1 committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    5971786 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2020

  1. twoProcessInstanceInfoSameStartDateTest 

    The twoProcessInstanceInfoSameStartDateTest was added along with other
minor changes based on review comments
    @hmatt1
    hmatt1 committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    2d6d719 View commit details
    Browse the repository at this point in the history

  2. Using this.startDate consistently

    @hmatt1
    hmatt1 committed Jul 28, 2020
    Configuration menu
    Copy the full SHA
    fcd6655 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2020

  1. Revert "Using this.startDate consistently" 

    This reverts commit fcd6655.
    @hmatt1
    hmatt1 committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    fdcc0d9 View commit details
    Browse the repository at this point in the history

  2. Revert "twoProcessInstanceInfoSameStartDateTest" 

    This reverts commit 2d6d719.
    @hmatt1
    hmatt1 committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    e100dbb View commit details
    Browse the repository at this point in the history

  3. Revert "ProcessInstanceInfo set start date when constructed" 

    This reverts commit 5971786.
    @hmatt1
    hmatt1 committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    b12f888 View commit details
    Browse the repository at this point in the history

  4. Set startDate in WorkflowProcessInstanceImpl 

    Set the start date when `start()` is called
    @hmatt1
    hmatt1 committed Jul 31, 2020
    Configuration menu
    Copy the full SHA
    dccf21b View commit details
    Browse the repository at this point in the history