Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JBPM-9452] ClassCastException fix #1840

Merged
merged 2 commits into from
Jun 8, 2021
Merged

[JBPM-9452] ClassCastException fix #1840

merged 2 commits into from
Jun 8, 2021

Conversation

hmatt1
Copy link
Contributor

@hmatt1 hmatt1 commented Jan 15, 2021

ClassCastException occurs when mapping DMN output to a Java Object in a BPMN

Thank you for submitting this pull request

JIRA:

JBPM-9452

I created a minimal, reproducible example here and verified this fixes the issue. I didn't see any unit tests for the RuleSetNodeInstance class so I wasn't sure what would be the best way to get an automated test in place for this. If you think we need one, I'd be happy to work on that and I'd appreciate some guidance to point me in the right direction.

referenced Pull Requests:

How to retest this PR or trigger a specific build:

  • a pull request please add comment: Jenkins retest this

  • a full downstream build please add comment: Jenkins run fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

JBPM-9452 ClassCastException fix
75ee8e1 
ClassCastException occurs when mapping DMN output to a Java Object in a BPMN
@kie-ci
Copy link

kie-ci commented Jan 15, 2021

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

15 similar comments
@kie-ci
Copy link

kie-ci commented Jan 15, 2021

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@kie-ci
Copy link

kie-ci commented Jan 15, 2021

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@kie-ci
Copy link

kie-ci commented Jan 15, 2021

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@kie-ci
Copy link

kie-ci commented Jan 15, 2021

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@kie-ci
Copy link

kie-ci commented Jan 15, 2021

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@kie-ci
Copy link

kie-ci commented Jan 15, 2021

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@kie-ci
Copy link

kie-ci commented Jan 15, 2021

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@kie-ci
Copy link

kie-ci commented Jan 15, 2021

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@kie-ci
Copy link

kie-ci commented Jan 15, 2021

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@kie-ci
Copy link

kie-ci commented Jan 15, 2021

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@kie-ci
Copy link

kie-ci commented Jan 15, 2021

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@kie-ci
Copy link

kie-ci commented Jan 15, 2021

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@kie-ci
Copy link

kie-ci commented Jan 15, 2021

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@kie-ci
Copy link

kie-ci commented Jan 15, 2021

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@kie-ci
Copy link

kie-ci commented Jan 15, 2021

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@bxf12315
Copy link
Member

Jenkins retest this

@bxf12315
Copy link
Member

Jenkins run fdb

@bxf12315
Copy link
Member

Jenkins retest this

@bxf12315
Copy link
Member

Jenkins run fdb

@hmatt1
Copy link
Contributor Author

hmatt1 commented Jan 23, 2021

@bxf12315 @vmiklos @atoulme do you know what's going on with the build?

@vmiklos
Copy link

vmiklos commented Jan 24, 2021

Sorry, no idea. I haven't contributed to this project in the recent past :-)

@hmatt1 hmatt1 changed the title JBPM-9452 ClassCastException fix [JBPM-9452] ClassCastException fix Jan 25, 2021
@hmatt1
Copy link
Contributor Author

hmatt1 commented Jan 25, 2021

@elguardian do you know what's going on with the build?

@bxf12315
Copy link
Member

Jenkins retest this

@bxf12315
Copy link
Member

Jenkins run fdb

@hmatt1
Copy link
Contributor Author

hmatt1 commented Jan 26, 2021

Jenkins retest this

@hmatt1
Copy link
Contributor Author

hmatt1 commented Jan 26, 2021

Jenkins run fdb

@hmatt1
Copy link
Contributor Author

hmatt1 commented Jan 26, 2021

@bxf12315 can we try the build again please?

@bxf12315
Copy link
Member

Jenkins run fdb

@hmatt1
Copy link
Contributor Author

hmatt1 commented Jan 27, 2021

Not sure how to debug this failure, can anyone help? Is it failing because of these changes?

@bxf12315
Copy link
Member

bxf12315 commented Jan 28, 2021 •
edited
Loading

Not sure how to debug this failure, can anyone help? Is it failing because of these changes?

You need to ask the gatekeep to review your PR. The UT failed, maybe do not relate your code.

@bxf12315
Copy link
Member

Jenkins retest this

@sonarcloud
Copy link

sonarcloud bot commented Jan 28, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@hmatt1
Copy link
Contributor Author

hmatt1 commented Mar 3, 2021

Thanks to Mario for the review 😄

Can someone help get this build to pass please? Hoping we can get this merged soon since it has been approved.

@hmatt1 hmatt1 mentioned this pull request Mar 5, 2021
Open
@hmatt1
Copy link
Contributor Author

hmatt1 commented May 25, 2021

Can someone help get this build to pass please? Hoping we can get this merged soon since it has been approved.

@kie-ci
Copy link

kie-ci commented May 25, 2021

Can one of the admins verify this patch?

9 similar comments
@kie-ci
Copy link

kie-ci commented May 25, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link

kie-ci commented May 25, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link

kie-ci commented May 25, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link

kie-ci commented May 25, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link

kie-ci commented May 25, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link

kie-ci commented May 25, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link

kie-ci commented May 25, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link

kie-ci commented May 25, 2021

Can one of the admins verify this patch?

@kie-ci
Copy link

kie-ci commented May 25, 2021

Can one of the admins verify this patch?

@sonarcloud
Copy link

sonarcloud bot commented May 25, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@hmatt1
Copy link
Contributor Author

hmatt1 commented Jun 1, 2021

Can someone help get this build to pass please? I can't see the failures from the downstream builds

@hmatt1
Copy link
Contributor Author

hmatt1 commented Jun 8, 2021

@elguardian are you able to help with this one? Not sure how to take this forward

@elguardian
Copy link
Member

this is very close to this problem

#1947

I am merging.

@elguardian elguardian merged commit 2e8014e into kiegroup:master Jun 8, 2021
@elguardian
Copy link
Member

thx for the contribution @hmatt1 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariofusco mariofusco mariofusco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hmatt1 @kie-ci @bxf12315 @vmiklos @elguardian @mariofusco