Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SRVLOGIC-349] Allow productization of integration-tests-jobs-service #32

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

gmunozfe
Copy link
Member

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Pull Request title is properly formatted: KOGITO-XYZ Subject
  • Pull Request title contains the target branch if not targeting main: [0.9.x] KOGITO-XYZ Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request checks
    Please add comment: Jenkins retest this

  • for a specific pull request check
    Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] tests

  • for quarkus branch checks
    Run checks against Quarkus current used branch
    Please add comment: Jenkins run quarkus-branch

  • for a quarkus branch specific check
    Run checks against Quarkus current used branch
    Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] quarkus-branch

  • for quarkus main checks
    Run checks against Quarkus main branch
    Please add comment: Jenkins run quarkus-main

  • for a specific quarkus main check
    Run checks against Quarkus main branch
    Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] quarkus-main

  • for quarkus lts checks
    Run checks against Quarkus lts branch
    Please add comment: Jenkins run quarkus-lts

  • for a specific quarkus lts check
    Run checks against Quarkus lts branch
    Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] quarkus-lts

  • for native checks
    Run native checks
    Please add comment: Jenkins run native

  • for a specific native check
    Run native checks
    Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] native

  • for native lts checks
    Run native checks against quarkus lts branch
    Please add comment: Jenkins run native-lts

  • for a specific native lts check
    Run native checks against quarkus lts branch
    Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] native-lts

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Quarkus-3 PR check is failing ... what to do ? The Quarkus 3 check is applying patches from the `.ci/environments/quarkus-3/patches`.

The first patch, called 0001_before_sh.patch, is generated from Openrewrite .ci/environments/quarkus-3/quarkus3.yml recipe. The patch is created to speed up the check. But it may be that some changes in the PR broke this patch.
No panic, there is an easy way to regenerate it. You just need to comment on the PR:

jenkins rewrite quarkus-3

and it should, after some minutes (~20/30min) apply a commit on the PR with the patch regenerated.

Other patches were generated manually. If any of it fails, you will need to manually update it... and push your changes.

@gmunozfe
Copy link
Member Author

@rgdoliveira @domhanak can you review?

@domhanak domhanak requested a review from rgdoliveira June 17, 2024 11:53
@rgdoliveira
Copy link
Member

Sorry for the delay, I was on PTO, I will check this PR soon.

@rgdoliveira
Copy link
Member

@gmunozfe I took a look at this PR and it seems that enabling the integration-tests-jobs-service module would require more changes and not sure if that's what we want.

This module will enable 3 new child modules:

  • integration-tests-jobs-service-common
  • integration-tests-jobs-service-quarkus (which contains more submodules)
  • integration-tests-jobs-service-springboot
  1. integration-tests-jobs-service-springboot module requires org.kie.kogito:kogito-maven-plugin which we exclude from product (see productized/modules in kogito-runtimes).

  2. integration-tests-jobs-service-common builds fine.

  3. integration-tests-jobs-service-quarkus failed when building submodule integration-tests-jobs-service-quarkus-management and the build failed complaining about missing org.kie.kogito:kogito-api-incubation-processes-services which we exclude from product in kogito-runtimes. But checking the integration-tests-jobs-service-quarkus-management module I could not find any reference to that missing module, so maybe it is transitive from some other?
    I also tried to remove the integration-tests-jobs-service-quarkus-management from integration-tests-jobs-service-quarkus to see if the other modules would build fine, but then the integration-tests-jobs-service-quarkus-messaging module failed about missing module org.kie:kogito-addons-quarkus-jobs-messaging which we exclude from product in kogito-runtimes.

So I guess it would need to evaluate whuch modules we want to include in the product before going ahead with this PR.

Btw, if you wanna try locally, you can build Drools, Kogito-runtimes and then Kogito-apps with this change.

What I usually do for each project build is:

  • Run ./productized/remove_modules.sh ./productized/modules to drop modules that should not be part of the product
  • Setup a different version in the poms of the project to avoid maven finding the artifacts with version 999-SNAPSHOT in Apache repository, for example: 999.0.0.redhat-20240703 or whatever you prefer
  • Build with maven

@rgdoliveira rgdoliveira requested a review from mareknovotny July 3, 2024 15:01
@gmunozfe
Copy link
Member Author

@rgdoliveira I've worked locally as you suggested, and apart from the new changes, jbpm-quarkus dependency needs to be removed. I've proposed this other PR in upstream to do it, let's see how it goes: apache#2077.

@mareknovotny
Copy link
Member

jenkins retest kogito-apps

@rgdoliveira
Copy link
Member

upstream PR apache#2077 is merged, I will sync midstream with upstream soon and I will test this PR again.

@rgdoliveira
Copy link
Member

I've synced midstream with upstream today (kogito-apps in #34) and I tested this PR locally and it built fine. I will merge it and I can double-check in the prod nightly tomorrow if everything will be ok.

@rgdoliveira rgdoliveira merged commit 55d7aad into kiegroup:main Jul 17, 2024
4 checks passed
@rgdoliveira
Copy link
Member

For the records latest prod nightly is green. Thanks for this contribution @gmunozfe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants