[9.99.x-prod] remove not productized artifacts from kogito-bom #16
Conversation
|
@gmunozfe cc |
| <dependency> | ||
| <groupId>org.kie.kogito</groupId> | ||
| <artifactId>kogito-addons-monitoring-elastic</artifactId> | ||
| <artifactId>kogito-drools</artifactId> | ||
| <version>${project.version}</version> | ||
| </dependency> |
There was a problem hiding this comment.
kogito-drools sources are not present, is it fine?
There was a problem hiding this comment.
I guess so, it is like this in upstream.
| <dependency> | ||
| <groupId>org.kie.kogito</groupId> | ||
| <artifactId>kogito-addons-quarkus-events-mongodb-deployment</artifactId> | ||
| <artifactId>kogito-quarkus-workflow-common</artifactId> | ||
| <version>${project.version}</version> | ||
| <classifier>sources</classifier> |
There was a problem hiding this comment.
To keep coherence, sources could be added below, wdyt?
There was a problem hiding this comment.
yeah, for this case the sources are defined before, I would say it should be changed the order in upstream
| <version>${project.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.kie.kogito</groupId> | ||
| <artifactId>kogito-addons-springboot-events-mongodb</artifactId> | ||
| <artifactId>kogito-quarkus-workflow-common-deployment</artifactId> | ||
| <version>${project.version}</version> | ||
| <classifier>sources</classifier> |
There was a problem hiding this comment.
yeah, for this case the sources are defined before, I would say it should be changed the order in upstream
| <groupId>org.kie.kogito</groupId> | ||
| <artifactId>kogito-addons-quarkus-process-management-deployment</artifactId> | ||
| <artifactId>kogito-quarkus-serverless-workflow-deployment</artifactId> | ||
| <version>${project.version}</version> | ||
| </dependency> |
There was a problem hiding this comment.
Missing sources for this artifact
There was a problem hiding this comment.
good point, this would need to be fixed in upstream too, but I guess not a blocker.
|
I pushed a commit removing the not wanted jar type in the pom that was added by mistake |
I believe this should be fixed by kiegroup/kogito-pipelines#20 |
rgdoliveira
force-pushed
the
9.99.x_drops_boms
branch
from
43b57bd to
b5795ca
Compare
|
I just rebased this PR, fingers crossed it will be green now |
This change is required for OSL 1.32 as there is no upstream release in community.
We usually keep the artifacts that are not productized in the BOM with their upstream version, but for this case it is not possible, hence removing them.
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
for pull request checks
Please add comment: Jenkins retest this
for a specific pull request check
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] tests
for quarkus branch checks
Run checks against Quarkus current used branch
Please add comment: Jenkins run quarkus-branch
for a quarkus branch specific check
Run checks against Quarkus current used branch
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch
for quarkus main checks
Run checks against Quarkus main branch
Please add comment: Jenkins run quarkus-main
for a specific quarkus main check
Run checks against Quarkus main branch
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] quarkus-main
for quarkus lts checks
Run checks against Quarkus lts branch
Please add comment: Jenkins run quarkus-lts
for native checks
Run native checks
Please add comment: Jenkins run native
for a specific native check
Run native checks
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] native
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.xto backport the original PR to the7.67.xbranch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.