Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds support for relative setupPath #69

Merged
merged 2 commits into from
May 11, 2023

Conversation

JoshMcCullough
Copy link
Contributor

Passing a relative value to as setupPath would cause a an error when pushing to the git repo. I added a check to resolve the setupPath if it is not absolute.

Before, this ...

const gh = new MockGithub(ghConfig, '_github_mock');

... would cause this ...

Pushing to _github_mock/repo/test/remote/origin
fatal: '_github_mock/repo/test/remote/origin' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

It could have been fixed by doing ...

const gh = new MockGithub(ghConfig, path.resolve(process.cwd(), '_github_mock'));

... but that shouldn't really be necessary from a user's perspective.

Copy link
Collaborator

@shubhbapna shubhbapna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@shubhbapna shubhbapna merged commit cd567ef into kiegroup:main May 11, 2023
@JoshMcCullough
Copy link
Contributor Author

You're welcome. And I see you already published the package. Thank you! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants