Fix issue with elements not becoming first responder fast enough #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harleyjcooper
approved these changes
Apr 3, 2019
|
It looks like this breaks |
When tapping an element, there is a check that ensures it becomes the first responder within a half second. This doesn't work for elements such as popover controls however, which only become first responder after the popover view finishes being presented (usually animated). In that case, there is a race condition as to whether the element will finish displaying before the polling interval completes. The fix here is to ensure that we wait for any animations to complete before trying to check that the element that has been tapped became first responder. One exception to this is when interacting with an accessibility element and not a view. In this case, the backing view for the may still be visible on screen, even though the element itself is not. An example of this is web views, where this would cause the test `-[WebViewTests testTappingLinks]` to fail.
justinseanmartin
force-pushed
the
jmartin/wait-for-animation-after-first-responder-tapped
branch
from
55f46dc to
60f3b1a
Compare
|
@harleyjcooper - Please take another look. I had to add an exception for cases like web views. I think this should go green now though. |
justinseanmartin
deleted the
jmartin/wait-for-animation-after-first-responder-tapped
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an UIPopover is presented in an animated fashion when an element is tapped, that element may not become first responder until after the animation is completed. This change gives waits for the animation to complete before checking that it became first responder.
Moving the
waitForAnimationsToFinishintroduced some other test failures when the element that became first responder is moved offscreen. For this reason, the additional check of![view isProbablyTappable]was added.