Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check preventing scroll UITableViewCells #1102

Conversation

justinseanmartin
Copy link
Contributor

@justinseanmartin justinseanmartin commented Apr 15, 2019

It prevents partially offscreen UITableViewCell elements from being made visible. I don't think this clause is necessary with an iOS 8+ minimum supported version we have now for KIF.

@justinseanmartin justinseanmartin changed the title [DNR] Remove some code that shouldn't be necessary Remove check preventing scroll UITableViewCells Apr 16, 2019
@harleyjcooper
Copy link
Contributor

LGTM

@justinseanmartin justinseanmartin merged commit f78e884 into kif-framework:master Apr 16, 2019
@justinseanmartin justinseanmartin deleted the jmartin/remove-some-stuff branch April 16, 2019 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants