Fix Xcode 11 (Beta) build error (implicit conversion warning) #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneidlinger
changed the title
Classes/KIFSystemTestActor.m
Outdated
| @@ -58,7 +58,7 @@ - (void)simulateMemoryWarning | |||
|
|
|||
| - (void)simulateDeviceRotationToOrientation:(UIDeviceOrientation)orientation | |||
| { | |||
| [[UIDevice currentDevice] setValue:[NSNumber numberWithInt:orientation] forKey:@"orientation"]; | |||
| [[UIDevice currentDevice] setValue:[NSNumber numberWithInt:(int)orientation] forKey:@"orientation"]; | |||
There was a problem hiding this comment.
Probably could just use @(orientation) and avoid the explicit cast. That'd be cleaner if it works IMO.
There was a problem hiding this comment.
Tested it locally and it fixes the compiler error. Went ahead and made that change in this branch.
There was a problem hiding this comment.
Nice, definitely cleaner. Thanks for the fast follow up!
|
Thanks for calling this out and the contribution @jneidlinger! Will merge this on green builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: