Update tappable to check if UIControl is enabled #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harleyjcooper
approved these changes
Dec 8, 2021
dostrander
force-pushed
the
dostrander/check-control-tapgesture
branch
from
b43619f to
fabaa36
Compare
justinseanmartin
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In iOS 15 a control will still have tap gestures though it is disabled. This will check if it is a control and enabled while checking for the tap gestures.
This also re-adds back in #1244 with a condition of checking the control. Removing introduces a bug where KIF will say this something is not tappable when it is
Context for re-adding this check
While I do think this check needs to be changed to accurately describe whether a view is tappable and on screen, my initial implementations did not work and would break in other ways. We need to think about what it means to be tappable on screen more clearly before removing/changing this check