-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump iOS minimum iOS deployment target to 11.0 #1283
Bump iOS minimum iOS deployment target to 11.0 #1283
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! The README already states that KIF officially supports iOS 11+, so this just makes it more explicit.
If you don't mind, it would be great to bump SPM and CocoaPods package definitions as well to match. If you don't want to scope creep, I can push that after your changes land.
Looks like there are some deprecated APIs to work through before we can land this though:
|
Looks like the test host app is using the deprecated |
2358994
to
7d85058
Compare
Any updates on merging this fix? |
Sorry for dropping the ball, I'd seen the last message from Daniel, but didn't see the subsequent push with the compiler error fixes. @danielob - Mind trying to push another commit to this PR branch and see if we can get green CI builds? For some reason the GH actions UI isn't letting me rekick it from the web. If not, @adamsousa, would you potentially want to pick this up and get it over the line in a new PR? |
I've noticed that when opening the project with Xcode 14.3, we get a warning that the target is not in the range of supported versions. Additionally, when trying to build the project using Carthage, we get a build error due to the deployment target being set to 8.0.
To address this issue, I've made changes to update the deployment target version to 11.0, which is within the range of supported deployment target versions for both Xcode and Carthage. This will ensure that the project can be built and run smoothly with the latest versions of Xcode and Carthage.
I've tested the changes locally and confirmed that they resolve the warning and error messages. Please review my changes and let me know if you have any feedback or concerns.